Skip to content

Conversation

@anobli
Copy link

@anobli anobli commented Jan 8, 2025

This updates googletest in order to use it with Zephyr.
The first patch update gtest itself to support Zephyr OS it self.
The second adds files used by Zephyr build system. If this is not acceptable, then I will drop it and find another way to integrate it to zephyr build system.

@google-cla
Copy link

google-cla bot commented Jan 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@anobli anobli force-pushed the abailon/zephyr/dev branch 3 times, most recently from c767d2d to 53e0458 Compare February 10, 2025 15:22
@anobli anobli requested a review from dkaszews February 10, 2025 15:26
@anobli anobli force-pushed the abailon/zephyr/dev branch from 53e0458 to ef017e6 Compare February 11, 2025 08:48
Although Zephyr has it own test suite, it doesn't work well with C++.
gtest and gmock seem more adapted.
This adds support of Zephyr OS in order to test C++ libraries and
applications.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
This update googletest to use it as Zephyr OS external module.
This allows downloading, configure and building googltest using
Zephyr west build system, without any user manipulation.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
@anobli anobli force-pushed the abailon/zephyr/dev branch from ef017e6 to 8e3886a Compare February 11, 2025 08:50
@anobli anobli requested a review from dkaszews February 11, 2025 08:50
@dkaszews
Copy link

What little I can review and understand looks good to me

@jeffwelder-ellenbytech
Copy link

+1

This is fantastic, and works great out of the box.
Attached is how I pulled it into my zephyr project.

manifest:
  remotes:
    - name: zephyrproject-rtos
      url-base: https://github.com/zephyrproject-rtos
    - name: anobli
      url-base: https://github.com/anobli

  projects:
    - name: googletest
      remote: anobli
      repo-path: googletest
      revision: 8e3886acac2e6058f4f540269f43b1f4a2700adc
    - name: zephyr
      remote: zephyrproject-rtos
      revision: v4.1.0
      import:
        name-blocklist:
          - hal_altera
          - hal_cypress
          - hal_infineon
          - hal_microchip
          - hal_nxp
          - hal_openisa
          - hal_silabs
          - hal_xtensa
          - hal_ti
          - loramac-node
          - ci-tools
          - edtt
          - sof
          - matter
  self:
    path: application

@awojasinski
Copy link

+1

@dkaszews can you merge it?

@dkaszews
Copy link

dkaszews commented Aug 6, 2025

@awojasinski I'm not a maintainer, I just reviewed it because I'd like to see it merged myself

@markus-schmailzl-bsh
Copy link

We are also really interested in the change. But we have the problem that the main zephyr thread is still running when the tests are executed. Does anybody else have this issue?

@thorsten-klein
Copy link

thorsten-klein commented Dec 8, 2025

Any updates on this? When will this be merged?

@anobli
Copy link
Author

anobli commented Dec 15, 2025

We are also really interested in the change. But we have the problem that the main zephyr thread is still running when the tests are executed. Does anybody else have this issue?

Could you elaborate more about the issue you are getting ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants