gapii: Connect under thread suspension. #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to retry tasks is quite a common thing to do, so make a helper for it.
I believe some traces were failing as we were attempting to connect after we had let threads continue execution. Instead connect while the debugger is still attached. There's no point dealing with versioning in the connection header at this point, so remove the conditional logic.
AWoloszyn
approved these changes
Aug 22, 2017
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
- Fix VertexInputData and VertexAttributeDivisor - Make VertexInputData optional(as spec states) - Add VertexAttributeDivisor to stateRebuilder - Fix the code around these two changes - update the sample trace
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
The map of divisors is not a dense map. The existing map unpacking functions require dense maps as documented. This change introduces a new function that will properly unpack a non-dense map, ignoring the keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe some traces were failing as we were attempting to connect after we had let threads continue execution. Instead connect while the debugger is still attached.
There's no point dealing with versioning in the connection header at this point, so remove the conditional logic.