Skip to content

Updated testsuite result_kind to use nested ErrorSet #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristonianJones merged 3 commits into from
May 5, 2025
Merged

Updated testsuite result_kind to use nested ErrorSet #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a39e305
Updated testsuite result_kind to use nested ErrorSet and remove depen…
ChinmayMadeshi May 1, 2025
d851a3d
Updated eval.proto with nested Status message instead of google.rpc.S…
ChinmayMadeshi May 1, 2025
32ac2c1
Updated the field documentaions in suite.proto.
ChinmayMadeshi May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proto/cel/expr/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ proto_library(
strip_import_prefix = "/proto",
deps = [
":value_proto",
"@com_google_googleapis//google/rpc:status_proto",
"@com_google_protobuf//:any_proto",
],
)

Expand Down
26 changes: 24 additions & 2 deletions proto/cel/expr/eval.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ syntax = "proto3";

package cel.expr;

import "google/protobuf/any.proto";
import "cel/expr/value.proto";
import "google/rpc/status.proto";

option cc_enable_arenas = true;
option go_package = "cel.dev/expr";
Expand Down Expand Up @@ -104,9 +104,31 @@ message ExprValue {
//
// The errors included depend on the context. See `ExprValue.error`.
message ErrorSet {
repeated google.rpc.Status errors = 1;
// Errors that could come up during evaluation phase.
repeated Status errors = 1;
}

// Each `Status` message contains three pieces of data: error code, error message,
// and error details.
//
// You can find out more about this error model and how to work with it in the
// [API Design Guide](https://cloud.google.com/apis/design/errors).
//
// Status value is intended to be wire and field compatible with `google.rpc.Status`.
message Status {
// The status code, which should be an enum value of [google.rpc.Code][].
int32 code = 1;

// A developer-facing error message, which should be in English. Any
// user-facing error message should be localized and sent in the
// [Status.details][] field, or localized by the client.
string message = 2;

// A list of messages that carry the error details. There is a common set of
// message types for APIs to use.
repeated google.protobuf.Any details = 3;
}

// A set of expressions for which the value is unknown.
//
// The unknowns included depend on the context. See `ExprValue.unknown`.
Expand Down