Caching directory creation refactor #2024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getuid()` call was leftover from when the substitution pattern had two holes for `/tmp/cvd/` and `<uid>` before `/cache`. reference: google@f4f0f10
This keeps all of the directory creation for `cvd fetch` together, and exposes the dependency of the `Downloaders` class. Also, relax the condition for `CanCache` to allow errors in `CanHardLink` to simply disable caching, instead of terminating execution. This allows cases where the cache directory has not been created, like in `downloaders_test.cpp`. However, I left the cache disabling flag in those unit tests. They are `cas_downloader` specific and have no need to validate initialization logic for caching.
cjreynol
force-pushed
the
caching_directory_creation_refactor
branch
from
0d00ce3 to
730bf76
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
jemoreira
reviewed
Jan 22, 2026
| } | ||
| return result; | ||
| if (!result.ok()) { | ||
| VLOG(1) << "Error during hard link check: " << result.error(); |
Member
There was a problem hiding this comment.
Shouldn't this be LOG(ERROR)? VLOG(1) is the equivalent of LOG(VERBOSE).
|
|
||
| } // namespace | ||
|
|
||
| Result<bool> CanCache(const std::string& target_directory, |
Member
There was a problem hiding this comment.
CanCache no longer returns an error under any circumstances. Change the signature to return bool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps all of the directory creation for
cvd fetchtogether, andexposes the dependency of the
Downloadersclass.Also, relax the condition for
CanCacheto allow errors inCanHardLinkto simply disable caching, instead of terminatingexecution. This allows cases where the cache directory has not been
created like in
downloaders_test.cpp.