-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix infinite loop in tool calling with FunctionCallingConfig mode='AN… #4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jayy-77
wants to merge
1
commit into
google:main
Choose a base branch
from
jayy-77:fix-infinite-loop-4179
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+215
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
tests/unittests/flows/llm_flows/test_tool_iteration_limit.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Unit tests for tool iteration limit to prevent infinite loops (Issue #4179).""" | ||
|
|
||
| import pytest | ||
| from google.adk.agents.invocation_context import ToolIterationsLimitExceededError | ||
| from google.adk.agents.llm_agent import Agent | ||
| from google.adk.agents.run_config import RunConfig | ||
| from google.genai import types | ||
|
|
||
| from ... import testing_utils | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_default_max_tool_iterations_value(): | ||
| """Test that the default max_tool_iterations is 50.""" | ||
| run_config = RunConfig() | ||
| assert run_config.max_tool_iterations == 50 | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_increment_tool_iteration_count(): | ||
| """Test that tool iteration counter increments and enforces limit.""" | ||
| agent = Agent(name='test_agent') | ||
| run_config = RunConfig(max_tool_iterations=3) | ||
|
|
||
| invocation_context = await testing_utils.create_invocation_context( | ||
| agent=agent, user_content='test', run_config=run_config | ||
| ) | ||
|
|
||
| # Should not raise for first 3 increments | ||
| invocation_context.increment_tool_iteration_count() # 1 | ||
| invocation_context.increment_tool_iteration_count() # 2 | ||
| invocation_context.increment_tool_iteration_count() # 3 | ||
|
|
||
| # 4th increment should raise ToolIterationsLimitExceededError | ||
| with pytest.raises(ToolIterationsLimitExceededError) as exc_info: | ||
| invocation_context.increment_tool_iteration_count() # 4 - exceeds limit | ||
|
|
||
| assert 'Max number of tool iterations limit of' in str(exc_info.value) | ||
| assert '3' in str(exc_info.value) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_reset_tool_iteration_count(): | ||
| """Test that tool iteration counter resets properly.""" | ||
| agent = Agent(name='test_agent') | ||
| run_config = RunConfig(max_tool_iterations=2) | ||
|
|
||
| invocation_context = await testing_utils.create_invocation_context( | ||
| agent=agent, user_content='test', run_config=run_config | ||
| ) | ||
|
|
||
| # First cycle: increment twice | ||
| invocation_context.increment_tool_iteration_count() # 1 | ||
| invocation_context.increment_tool_iteration_count() # 2 | ||
|
|
||
| # Reset the counter | ||
| invocation_context.reset_tool_iteration_count() | ||
|
|
||
| # Should not raise after reset - can increment again | ||
| invocation_context.increment_tool_iteration_count() # 1 (reset) | ||
| invocation_context.increment_tool_iteration_count() # 2 (reset) | ||
|
|
||
| # 3rd increment should raise | ||
| with pytest.raises(ToolIterationsLimitExceededError): | ||
| invocation_context.increment_tool_iteration_count() # 3 - exceeds limit | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_max_tool_iterations_disabled(): | ||
| """Test that setting max_tool_iterations to 0 disables enforcement.""" | ||
| agent = Agent(name='test_agent') | ||
| run_config = RunConfig(max_tool_iterations=0) | ||
|
|
||
| invocation_context = await testing_utils.create_invocation_context( | ||
| agent=agent, user_content='test', run_config=run_config | ||
| ) | ||
|
|
||
| # Should not raise even after many increments when limit is disabled | ||
| for _ in range(100): | ||
| invocation_context.increment_tool_iteration_count() | ||
|
|
||
| # No exception raised - test passes | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_max_tool_iterations_validator(): | ||
| """Test that RunConfig validator warns about disabled limit.""" | ||
| import logging | ||
| import warnings | ||
|
|
||
| # Setting to 0 should trigger a warning | ||
| with warnings.catch_warnings(record=True): | ||
| warnings.simplefilter("always") | ||
| run_config = RunConfig(max_tool_iterations=0) | ||
| assert run_config.max_tool_iterations == 0 | ||
|
|
||
| # Setting to positive value should not raise | ||
| run_config = RunConfig(max_tool_iterations=50) | ||
| assert run_config.max_tool_iterations == 50 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of
test_max_tool_iterations_validatordoes not correctly test for the warning message. The validator useslogger.warning, which is not captured bywarnings.catch_warningsby default. To properly test that the warning is logged, you should use thecaplogfixture provided bypytest. This will ensure the test is robust and correctly verifies the validator's behavior.