Skip to content

Conversation

@qieqieplus
Copy link
Contributor

Current implementation of transfer_to_agent doesn't enforce strict constraints on agent names,
We could use JSON Schema's enum definition to implement stricter constraints:

Before

[{
	"type": "function",
	"function": {
		"name": "transfer_to_agent",
		"description": "Transfer the question to another agent.\n\nThis tool hands off control to another agent when it's more suitable to answer the user's question according to the agent's description.\n\nArgs:\n  agent_name: the agent name to transfer to.\n",
		"parameters": {
			"type": "object",
			"properties": {
				"agent_name": {
					"type": "string"
				}
			}
		}
	}
}]

After

[{
	"type": "function",
	"function": {
		"name": "transfer_to_agent",
		"description": "Transfer the question to another agent.\n\nThis tool hands off control to another agent when it's more suitable to answer the user's question according to the agent's description.\n\nArgs:\n  agent_name: the agent name to transfer to.\n",
		"parameters": {
			"type": "object",
			"properties": {
				"agent_name": {
					"type": "string",
					"enum": ["agent_a", "agent_b", "agent_c"]
				}
			}
		}
	}
}]

@adk-bot adk-bot added bot triaged core [Component] This issue is related to the core interface and implementation labels Aug 8, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Aug 8, 2025

Response from ADK Triaging Agent

Hello @qieqieplus, thank you for your contribution!

To help us review this PR, could you please:

  1. Associate a GitHub issue with this PR. If one doesn't exist, please create one.
  2. Add a "Testing Plan" section to the PR description explaining how you've tested these changes.

This information will help reviewers to review your PR more efficiently. Thanks!

@hangfei
Copy link
Collaborator

hangfei commented Nov 14, 2025

Could you resolve the conflicts so we can merge?

@qieqieplus
Copy link
Contributor Author

Could you resolve the conflicts so we can merge?

Done.
I noticed there is a update of agent_transfer.py,
with a new reference to _TRANSFER_TO_AGENT_FUNCTION_NAME,
so I updated this during resolution to match the refactoring.

@xuanyang15 xuanyang15 self-assigned this Nov 23, 2025
copybara-service bot pushed a commit that referenced this pull request Nov 25, 2025
Merge #2437

Current implementation of `transfer_to_agent` doesn't enforce strict constraints on agent names, we could use JSON Schema's enum definition to implement stricter constraints.

Co-authored-by: Xuan Yang <xygoogle@google.com>
COPYBARA_INTEGRATE_REVIEW=#2437 from qieqieplus:main 052e8e7
PiperOrigin-RevId: 836410397
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 25, 2025

Thank you @qieqieplus for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 4a42d0d.

Closing this PR as the changes are now in the main branch.

@adk-bot adk-bot closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants