Ensure AuthClient is cached #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
commented
Aug 17, 2024
sethvargo
force-pushed
the
sethvargo/cache
branch
from
af99dc0 to
799a13d
Compare
|
@sethvargo The action is not built here. |
sethvargo
force-pushed
the
sethvargo/cache
branch
from
799a13d to
149dcf2
Compare
Contributor
Author
Fixed @GregoireW |
|
Now I got 2 api when I launch my test with 200 files so this is good. I notice a real application with ~75 api call for 3500 files, not sure why, but let say it is not related. it is already a huge improvement. Thank you! |
Contributor
Author
|
@verbanicm ready for review @danielbankhead - I'd still like your feedback on #373 (comment). |
verbanicm
approved these changes
Aug 19, 2024
Merged
sethvargo
pushed a commit
that referenced
this pull request
Aug 19, 2024
## What's Changed * Ensure AuthClient is cached by @sethvargo in #373 * Use the default client instead by @sethvargo in #374 **Full Changelog**: v2.1.2...bf31481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364
/cc @GregoireW @danielbankhead could you please test this?
@verbanicm hold on merge until further testing.