chore: autogenerate settings documentation#12451
Conversation
Summary of ChangesHello @cornmander, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the generation of settings documentation, adds drift detection to ensure documentation accuracy, and integrates this process into the CI pipeline. This enhancement reduces manual effort and improves the reliability of the settings documentation. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +2.57 kB (+0.01%) Total Size: 20.3 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces a script to auto-generate the settings documentation from the settings schema, which is a great step for maintainability. The script and its integration test look solid. However, in the process of migrating the descriptions to the schema, some have been over-simplified, leading to a significant loss of critical information in the documentation. I've pointed out a few places where the documentation is now either incorrect or critically incomplete, which could prevent users from using certain features correctly. These descriptions should be improved in the schema file to ensure the generated documentation is accurate and complete.
This comment has been minimized.
This comment has been minimized.
jacob314
left a comment
There was a problem hiding this comment.
Done with review. Looks good overall. Approved after these comments are resolved. We should probably file a tracking issue to show these descriptions in the settings dialog now that they are useful.
9c2cf9b to
01ee66a
Compare
01ee66a to
709f228
Compare
709f228 to
31a8ab2
Compare
|
All comments resolved. |
scripts/generate-settings-schema.ts
Outdated
| checkOnly: boolean; | ||
| } | ||
|
|
||
| const CUSTOM_DEFINITIONS: Record<string, JsonSchema> = { |
There was a problem hiding this comment.
These CUSTOM_DEFINITIONS worry me. Can you instead refactor so this info is captured in settingsSchema. If it is here, it will get inconsistent and people/LLMs modifying settingsSchema.ts will forget to make the needed changes.
jacob314
left a comment
There was a problem hiding this comment.
Looks good! Approved once concern about the off to the side data in generate-settings-schema.ts is addressed.
|
Great call-out. I moved every |
|
I also added a test to make sure that the type definitions and schema are kept in sync. |
95d2f18 to
b91f9e5
Compare

Summary
npm run docs:settings -- --checkin lint CITesting
Fixes #11058