Skip to content

ode: refactor integrator initialization and documentation #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
soypat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ode: refactor integrator initialization and documentation #62

soypat wants to merge 1 commit into from

Conversation

@soypat
Copy link
Contributor

@soypat soypat commented Jun 3, 2023

  • Removed DefaultParameters as it was just the zero value for Parameters.
  • Consolidated documentation on the Step method: before the returned value was stated as being a "suggestion" when in reality it is the step the algorithm takes which may differ when the algorithm is adaptive
  • Added mustValidate methods on types IVP, IVP2 and Parameters to catch NaN, Inf, nil, or just invalid configurations early and consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@soypat