conncheck: allow to disable via config #1052
Merged
+75
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienschmidt
changed the title
julienschmidt
force-pushed
the
connncheck_optional
branch
from
2f61272 to
f7268f2
Compare
julienschmidt
force-pushed
the
connncheck_optional
branch
from
75824b8 to
d23e1ee
Compare
|
I am not good at English, but I feel "liveness" is commonly used in context of healthcheck. |
|
Both seems to be used. E.g. Kubernetes uses "Liveness", in Red Hat Enterprise Virtualization "Liveliness" is used. |
julienschmidt
force-pushed
the
connncheck_optional
branch
from
d23e1ee to
fc27b32
Compare
|
@methane PTAL |
methane
approved these changes
Jan 7, 2020
vmg
approved these changes
Jan 7, 2020
julienschmidt
force-pushed
the
connncheck_optional
branch
from
fc27b32 to
449e060
Compare
|
I just pushed another minimal change, where I just fixed two occurrences of the word liveness in the description of the DSN param to be lower-cased. |
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* conncheck: allow to disable via config * dsn: refactor writing of params in FormatDSN
tz70s
pushed a commit
to tz70s/mysql
that referenced
this pull request
Sep 5, 2020
* conncheck: allow to disable via config * dsn: refactor writing of params in FormatDSN
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to disable the conncheck introduced in #934 via config / DSN. The default is to perform this liveliness check of connections on supported platforms, if not explicitly disabled.
Fixes #996
Checklist