proc: fix sigpanics in swiss map iterator#4260
Closed
derekparker wants to merge 1 commit intomasterfrom
Closed
Conversation
The fix adds validation at every point where pointers are dereferenced or struct fields are accessed: - loadTypes: check dirPtr after maybeDereference for both small map (dirLen <= 0) and large map (dirLen > 0) paths. - loadCurrentTable: check tab after maybeDereference; check all toField() returns for the index, groups, groups.data, and groups.lengthMask fields; extend existing groups nil check to also check Unreadable. - loadCurrentGroup: check toField() returns for slots and ctrl fields. In all cases, the map is marked as Unreadable with a descriptive error message rather than panicking. Fixes #4005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix adds validation at every point where pointers are dereferenced or struct fields are accessed:
In all cases, the map is marked as Unreadable with a descriptive error message rather than panicking.
Fixes #4005