-
Notifications
You must be signed in to change notification settings - Fork 5
Optimize cypress #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Optimize cypress #209
Conversation
…rganization and clarity
📝 WalkthroughWalkthroughThis pull request adds Cypress test parallelization by integrating the cypress-split plugin, configuring CI to run three shards, adding the dependency, and adjusting tests to work with the split/parallel setup. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/continuous-integration.yml:
- Around line 123-131: Update the Cypress run step in the CI workflow (the
"Cypress run (shard ${{ matrix.shard }}/3)" job) to include the dashboard
grouping flags so shards are recorded as one build: add --group with a value
like shard-${{ matrix.shard }}/3 and --ci-build-id using ${{ github.run_id }} to
the existing yarn run cypress run --record --key invocation so each shard is
grouped and associated with the same CI build on Cypress Cloud.
🧹 Nitpick comments (1)
.github/workflows/continuous-integration.yml (1)
27-32: Each shard duplicates the full backend/frontend setup.The shard matrix causes the entire job — including Postgres, Elixir backend compilation, and frontend build — to run 3 times. This triples CI resource consumption. Consider splitting the workflow into a setup job that builds artifacts, and a test job that uses those artifacts with the shard matrix.
mdshamoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Summary by CodeRabbit
Tests
Chores