Skip to content

Added exception handling for WinError6 #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Added exception handling for WinError6 #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added exception handling for WinError6
  • Loading branch information
@benthayer
benthayer committed Oct 22, 2019
commit 0bbba6ba41b6f00bedc8f9fd3c174ae5c81fe0bd
7 changes: 5 additions & 2 deletions git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,11 @@ def __del__(self):
proc.stderr.close()

# did the process finish already so we have a return code ?
if proc.poll() is not None:
return
try:
if proc.poll() is not None:
return
except OSError as ex:
log.info("Ignored error after process had died: %r", ex)

# can be that nothing really exists anymore ...
if os is None or getattr(os, 'kill', None) is None:
Expand Down