Skip to content

Fix how Diff handles commits that contain submodule changes #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Fix how Diff handles commits that contain submodule changes #947

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
862cba8
Initial stab at fixing diffs involving submodule changes
thetwoj Oct 20, 2019
c596b03
Adding command to init-tests-after-clone.sh to make sure submodules a…
thetwoj Oct 20, 2019
c1db9e0
Added new test to cover the issue this fix addresses (#891)
thetwoj Oct 21, 2019
dd546a1
Removing f-strings to maintain 3.4 and 3.5 compatability
thetwoj Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding command to init-tests-after-clone.sh to make sure submodules a… 
…re recursively cloned as well
  • Loading branch information
@thetwoj
thetwoj committed Oct 20, 2019
commit c596b035734352e0f08adb478c952289f62ca232
3 changes: 2 additions & 1 deletion init-tests-after-clone.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ git checkout master || git checkout -b master
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard HEAD~1
git reset --hard __testing_point__
git reset --hard __testing_point__
git submodule update --init --recursive