Skip to content

BF (codename "happy travis"): trying to address lints etc to make Travis green again #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 11, 2017
Merged

BF (codename "happy travis"): trying to address lints etc to make Travis green again #702

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6ee08fc
RF: primarily flake8 lints + minor RF to reduce duplication in PATHEXT
yarikoptic Nov 28, 2017
086af07
BF(PY26): {} -> {0}, i.e. explicit index for .format()
yarikoptic Nov 28, 2017
e1aea3a
BF: crazy tests ppl pass an object for status... uff -- catch TypeErr…
yarikoptic Nov 28, 2017
c352dba
RF: last of flake8 fails - avoid using temp variable in a test
yarikoptic Nov 28, 2017
42e89cc
RF(+BF?): refactor hooks creation in a test, and may be make it compa…
yarikoptic Nov 28, 2017
d723148
ENH: add appveyor recipe to establish rdesktop login into the test box
yarikoptic Nov 28, 2017
dcfe242
ENH: also report where on sh, and echo msg when entering on_finish
yarikoptic Nov 28, 2017
0a67f25
RF: no "need" for custom shebang on windows since just does not work
yarikoptic Nov 28, 2017
6253625
Disable (but keep for future uses commented out) hook into appveyor s…
yarikoptic Nov 28, 2017
91b9bc4
RF(TST): skip all tests dealing with hooks on windows
yarikoptic Nov 28, 2017
b4459ca
BF(WIN): use where instead of which while looking for git
yarikoptic Nov 28, 2017
cc34077
RF: use HIDE_WINDOWS_KNOWN_ERRORS instead of is_win to skip hooks tests
yarikoptic Nov 28, 2017
4d851a6
BF(WIN): where could report multiple hits, so choose first
yarikoptic Nov 28, 2017
f48d087
to keep travis busy - adding myself to AUTHORS
yarikoptic Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BF(WIN): use where instead of which while looking for git
  • Loading branch information
@yarikoptic
yarikoptic committed Nov 28, 2017
commit b4459ca7fd21d549a2342a902cfdeba10c76a022
5 changes: 4 additions & 1 deletion git/test/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
except ImportError:
import mock

from git.compat import is_win


class TestGit(TestBase):

Expand Down Expand Up @@ -177,7 +179,8 @@ def test_refresh(self):
self.assertRaises(GitCommandNotFound, refresh, "yada")

# test a good path refresh
path = os.popen("which git").read().strip()
which_cmd = "where" if is_win else "which"
path = os.popen("{0} git".format(which_cmd)).read().strip()
refresh(path)

def test_options_are_passed_to_git(self):
Expand Down