FetchInfo.re_fetch_result has no reason to be public #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And when using the API interactively, having it show up as public is confusing.
|
Thanks a lot for your contribution, this makes total sense, and my apologies for getting to this PR that late! |
|
Thanks @Byron! |
riley-martine
pushed a commit
to riley-martine/GitPython
that referenced
this pull request
Dec 7, 2023
…ch_result FetchInfo.re_fetch_result has no reason to be public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And when using the API interactively, having it show up as public is
confusing.