Skip to content

Use proper syntax for conditional expressions. #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2016
Merged

Use proper syntax for conditional expressions. #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use proper syntax for conditional expression 
(instead of abusing the "short-circuit" property of logical operations)
  • Loading branch information
@Xender
Xender committed May 26, 2016
commit 39164b038409cb66960524e19f60e83d68790325
2 changes: 1 addition & 1 deletion git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def execute(self, command,
bufsize=-1,
stdin=istream,
stderr=PIPE,
stdout=with_stdout and PIPE or open(os.devnull, 'wb'),
stdout=PIPE if with_stdout else open(os.devnull, 'wb'),
shell=self.USE_SHELL,
close_fds=(os.name == 'posix'), # unsupported on windows
universal_newlines=universal_newlines,
Expand Down