Skip to content

Add 'sshkey' context manager #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2015
Merged

Add 'sshkey' context manager #242

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1287f69
Fix some typos
teeberg Jan 21, 2015
261aedd
Add 'sshkey' context manager
teeberg Jan 21, 2015
34c0831
Add method to query environment
teeberg Jan 22, 2015
2a9b2f2
Rename 'environment' and 'set_environment'
teeberg Jan 22, 2015
98a17a2
Add SSH wrapper to MANIFEST.in
teeberg Jan 22, 2015
6f03861
Add a few tests
teeberg Jan 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add method to query environment
  • Loading branch information
@teeberg
teeberg committed Jan 22, 2015
commit 34c0831453355e09222ccc6665782d7070f5ddab
3 changes: 3 additions & 0 deletions git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,9 @@ def as_text(stdout_value):
else:
return stdout_value

def environment(self):
return self._environment

def set_environment(self, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at the implementation, I'd be tempted to call this method update_environment. set_environment seems to be more like this:

res = self._environment
self._environment = kwargs
return res

"""
Set environment variables for future git invocations. Return all changed
Expand Down