Skip to content

Fix another bug found by Fedora users, indented config sections. Newer RawConfigParser handles them fine, as does git config. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix another bug found by Fedora users, indented config sections. Newer RawConfigParser handles them fine, as does git config. #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle indented config sections 
This brings over some new code from RawConfigParser that handles lines
that start with spaces but are also sections themselves, eg:

[color]
    ui = auto
  [color "branch"]

Previously this would cause a traceback.
(https://bugzilla.redhat.com/show_bug.cgi?id=706218)
  • Loading branch information
@jkeating
jkeating committed May 25, 2011
commit d27cd97d8317094454510e904b49c5c537fa202c
5 changes: 5 additions & 0 deletions git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,11 @@ def _read(self, fp, fpname):
if line.split(None, 1)[0].lower() == 'rem' and line[0] in "rR":
# no leading whitespace
continue
# continuation line?
if line[0].isspace() and cursect is not None and optname:
value = line.strip()
if value:
cursect[optname] = "%s\n%s" % (cursect[optname], value)
else:
# is it a section header?
mo = self.SECTCRE.match(line)
Expand Down