Skip to content

Better document IterableObj.iter_items and improve some subclasses #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Better document IterableObj.iter_items and improve some subclasses #1780

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53e7383
Remove explicit PushInfo/FetchInfo inheritance from object
EliahKagan Dec 22, 2023
96fc354
Add tests for current Submodule.iter_items behavior
EliahKagan Dec 22, 2023
f5dc1c4
Expand "invalid hash" test to assert normal StopIteration
EliahKagan Dec 22, 2023
c3c008c
In Submodule.iter_items, don't attach second empty iterator
EliahKagan Dec 22, 2023
dfee31f
Improve self-documentation of IterableObj and related classes
EliahKagan Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove explicit PushInfo/FetchInfo inheritance from object 
I had missed these in f78587f (#1725).
  • Loading branch information
@EliahKagan
EliahKagan committed Dec 22, 2023
commit 53e73830f64e13a88b0e246fb825944a6fe2848e
4 changes: 2 additions & 2 deletions git/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def to_progress_instance(
return progress


class PushInfo(IterableObj, object):
class PushInfo(IterableObj):
"""
Carries information about the result of a push operation of a single head::

Expand Down Expand Up @@ -300,7 +300,7 @@ def raise_if_error(self) -> None:
raise self.error


class FetchInfo(IterableObj, object):
class FetchInfo(IterableObj):
"""
Carries information about the results of a fetch operation of a single head::

Expand Down