Skip to content

Test macOS on CI #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Test macOS on CI #1752

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2813e94
Add macOS test jobs to CI matrix
EliahKagan Dec 1, 2023
789baa1
Use macOS 13 on CI
EliahKagan Dec 1, 2023
f6f335f
Temporarily break test_blocking_lock_file on Windows
EliahKagan Dec 1, 2023
c16e4f3
Restore longer extra time for Windows, and add for macOS
EliahKagan Dec 1, 2023
d15f891
macOS needs even more extra time in test_blocking_lock_file
EliahKagan Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Temporarily break test_blocking_lock_file on Windows 
To compare how much extra wait time Windows and macOS usually need.
  • Loading branch information
@EliahKagan
EliahKagan committed Dec 1, 2023
commit f6f335ffcd55af5367692d338d78cf0465c34514
2 changes: 1 addition & 1 deletion test/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def test_blocking_lock_file(self):
self.assertRaises(IOError, wait_lock._obtain_lock)
elapsed = time.time() - start
extra_time = 0.02
if os.name == "nt" or sys.platform == "cygwin":
if sys.platform == "cygwin": # FIXME: Put back native Windows check.
extra_time *= 6 # NOTE: Indeterministic failures without this...
self.assertLess(elapsed, wait_time + extra_time)

Expand Down