Skip to content

Fix up checks in Makefile and make them portable #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 15, 2023
Merged

Fix up checks in Makefile and make them portable #1661

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6fb2318
Reference HEAD in Makefile (more portable than head)
EliahKagan Sep 11, 2023
335d03b
Have Makefile use git tag to sort the tags
EliahKagan Sep 11, 2023
b1c61d9
Make "git tag" sort our SemVer-ish tags correctly
EliahKagan Sep 13, 2023
cc202cc
Improve when and how Makefile suggests virtual env
EliahKagan Sep 13, 2023
b54c346
Use "python" in the virtual env, "python3" outside
EliahKagan Sep 13, 2023
ae9405a
LF line endings for scripts that may need them
EliahKagan Sep 13, 2023
f5da163
Have "make release" check other release preconditions
EliahKagan Sep 13, 2023
5cf7f97
Fix non-venv branch always failing
EliahKagan Sep 13, 2023
6495d84
Extract checks from release target to script
EliahKagan Sep 14, 2023
4b1c564
Extract build from force_release target to script
EliahKagan Sep 14, 2023
729372f
Prevent buggy interaction between MinGW and WSL
EliahKagan Sep 14, 2023
ba84db4
Fix message wording that was opposite of intended
EliahKagan Sep 14, 2023
de40e68
Ignore some other virtual environment directories
EliahKagan Sep 14, 2023
693d041
make `.gitattributes` file more generic
Byron Sep 15, 2023
962f747
submodules don't contribute to the release; ignore their changes
Byron Sep 15, 2023
d18d90a
Use 'echo' where possible to avoid explicit newlines
Byron Sep 15, 2023
5919f8d
Be explicit on how to interpret the data table
Byron Sep 15, 2023
1e0b3f9
refinements to `build-reelase.sh`
Byron Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix message wording that was opposite of intended 
This also makes a correct but confusing comment clearer.
  • Loading branch information
@EliahKagan
EliahKagan committed Sep 14, 2023
commit ba84db487a31c593fe0618a63f80709e405039c9
4 changes: 2 additions & 2 deletions check-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ readonly changes_path='doc/source/changes.rst'
printf 'Checking current directory.\n'
test "$(cd -- "$(dirname -- "$0")" && pwd)" = "$(pwd)" # Ugly, but portable.

printf 'Checking that %s and %s exist and have no committed changes.\n' \
printf 'Checking that %s and %s exist and have no uncommitted changes.\n' \
"$version_path" "$changes_path"
test -f "$version_path"
test -f "$changes_path"
Expand All @@ -40,7 +40,7 @@ printf '%-14s = %s\n' 'VERSION file' "$version_version" \
'HEAD SHA' "$head_sha" \
'Latest tag SHA' "$latest_tag_sha"

# Check that latest tag matches version and is the current HEAD we're releasing
# Check that the latest tag and current version match the HEAD we're releasing.
test "$version_version" = "$changes_version"
test "$latest_tag" = "$version_version"
test "$head_sha" = "$latest_tag_sha"
Expand Down