Skip to content

Fix CVE-2023-40590 #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2023
+52 −18
Merged

Fix CVE-2023-40590 #1636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6029211
Fix CVE-2023-40590
EliahKagan Aug 30, 2023
94e0fb0
Add a unit test for CVE-2023-40590
EliahKagan Aug 30, 2023
7611cd9
Don't check form of version number
EliahKagan Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't check form of version number 
This changes the regex in test_it_executes_git_not_from_cwd so
that (unlike test_it_executes_git_to_shell_and_returns_result) it
only checks that the output starts with the words "git version",
and not the form of whatever follows those words.
  • Loading branch information
@EliahKagan
EliahKagan committed Aug 30, 2023
commit 7611cd909b890b971d23bce3bd4244ad1c381f22
2 changes: 1 addition & 1 deletion test/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def test_it_executes_git_not_from_cwd(self):
os.chmod(impostor_path, 0o755)

with _chdir(tmpdir):
self.assertRegex(self.git.execute(["git", "version"]), r"^git version [\d\.]{2}.*$")
self.assertRegex(self.git.execute(["git", "version"]), r"^git version\b")

def test_it_accepts_stdin(self):
filename = fixture_path("cat_file_blob")
Expand Down