Skip to content

Conversation

NHanser
Copy link
Contributor

@NHanser NHanser commented Dec 23, 2021

Use NUL character instead of semicolon to extract meta and path. Avoid errors in during git diff when dealing with filenames containing semicolons

Use NUL character instead of semicolon to extract meta and path. Avoid errors in during git diff when dealing with filenames containing semicolons
@Byron
Copy link
Member

Byron commented Dec 24, 2021

Thanks a lot for the contribution, it's much appreciated!

It looks like CI is currently broken as it pulls in a more recent version of mypi, which now takes offense in additional portions of the code.

@Yobmod Is this something that could be fixed, maybe alongside pinning the mypi version so this won't sneak up again? Thanks for your advice.

@Byron
Copy link
Member

Byron commented Jan 7, 2022

Mypi is now used for advisory only, and set to not fail CI anymore.

That way we can fix the type-system from time to time as the need arises, but won't allow it to prevent changes anymore.
I'd hope there are better ways to do this, like pinning the mypi version.

@Byron Byron added this to the v3.1.25 - Bugfixes milestone Jan 7, 2022
@Byron Byron merged commit 01f0988 into gitpython-developers:main Jan 7, 2022
@Byron
Copy link
Member

Byron commented Jan 7, 2022

I am sorry but had to revert this PR with 3ef81e1 as it did cause breakage in main for reasons I didn't uncover yet. It's odd that CI didn't discover this earlier.

Maybe you could have another look and we can try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants