Skip to content

Do not call get_user_id if it is not needed #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yobmod merged 9 commits into from
Aug 6, 2021
Merged

Do not call get_user_id if it is not needed #1314

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39f12bd
Do not call get_user_id if it is not needed
eric-wieser Aug 3, 2021
ff0ecf7
Fix mypy
eric-wieser Aug 3, 2021
335e59d
Update config.py
eric-wieser Aug 3, 2021
05c77cf
Merge branch 'main' into patch-1
eric-wieser Aug 3, 2021
994f387
Use get instead of get_value
eric-wieser Aug 3, 2021
a71b617
Merge branch 'gitpython-developers:main' into patch-1
eric-wieser Aug 3, 2021
70b50e0
Fix test
eric-wieser Aug 3, 2021
d490d66
Try a better test
eric-wieser Aug 4, 2021
ec04ea0
Update test_util.py
eric-wieser Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into patch-1
  • Loading branch information
@eric-wieser
eric-wieser authored Aug 3, 2021
commit 05c77cf06e82f7932fb9775fad74251ad6c8aa4f
11 changes: 5 additions & 6 deletions git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,14 +710,13 @@ def read_only(self) -> bool:
return self._read_only

@overload
def get_value(self, section: str, option: str, default: Optional[str] = None
) -> str:
...
def get_value(self, section: str, option: str, default: None = None) -> str: ...

@overload
def get_value(self, section: str, option: str, default: Optional[float] = None
) -> float:
...
def get_value(self, section: str, option: str, default: str) -> str: ...

@overload
def get_value(self, section: str, option: str, default: float) -> float: ...

def get_value(self, section: str, option: str, default: Union[int, float, str, bool, None] = None
) -> Union[int, float, str, bool]:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.