Skip to content

Adds repo.is_valid_object() check. #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2021
Merged

Adds repo.is_valid_object() check. #1267

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
385a8c6
Adds repo.is_valid_object check
bytefluxio Jun 5, 2021
ac4fe6e
Fixes type check for is_valid_object
bytefluxio Jun 5, 2021
4832aa6
Removes local variable 'e' that is assigned to but never used
bytefluxio Jun 5, 2021
fb2461d
Removes unused import
bytefluxio Jun 5, 2021
464504c
Removes f-string syntax for p35 compatibility
bytefluxio Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes type check for is_valid_object
  • Loading branch information
@bytefluxio
bytefluxio committed Jun 5, 2021
commit ac4fe6efbccc2ad5c2044bf36e34019363018630
2 changes: 1 addition & 1 deletion git/repo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def is_ancestor(self, ancestor_rev: 'Commit', rev: 'Commit') -> bool:
raise
return True

def is_valid_object(self, sha: str, object_type: Union['blob', 'commit', 'tree', 'tag'] = None) -> bool:
def is_valid_object(self, sha: str, object_type: str = None) -> bool:
try:
complete_sha = self.odb.partial_to_complete_sha_hex(sha)
object_info = self.odb.info(complete_sha)
Expand Down