typing-extensions dependency not correct?

[wardy3]

Hi

I am getting this error:

   from git import Repo
1361/usr/local/lib/python3.7/site-packages/git/__init__.py:8: in <module>
1362    from git.exc import *                       # @NoMove @IgnorePep8
1363/usr/local/lib/python3.7/site-packages/git/exc.py:10: in <module>
1364    from git.compat import safe_decode
1365/usr/local/lib/python3.7/site-packages/git/compat.py:32: in <module>
1366    from git.types import TBD
1367/usr/local/lib/python3.7/site-packages/git/types.py:12: in <module>
1368    from typing_extensions import Final, Literal, SupportsIndex  # noqa: F401
1369E   ImportError: cannot import name 'SupportsIndex' from 'typing_extensions' (/usr/local/lib/python3.7/site-packages/typing_extensions.py)

I think it's because the dependency is listed as 3.7.4.0 but SupportsIndex wasn't added until May 2020, which looks like 3.7.4.3?

thanks for the great work

[Yobmod]

Thanks for posting.

I've updated the typing-extensions dependancy to 3.7.4.3 (released Aug 2020)
Again the tests all pass because they use the most recent minor versions, but there are API changes in minor versions.

I guess for users it will be easier to update typing-extensions than gitpython, so doesnt need another release just for this.

[wardy3]

indeed. thanks!

…

On Wed, 23 Jun 2021 at 11:30, Dominic ***@***.***> wrote: I've updated the typing-extensions dependancy to 3.7.4.3. I guess for users it will be just as easier to update typing-extensions than gitpython, so doesnt need another release just for this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1274 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSPYPULK6ZTC5UHJRW3KWTTUE2J3ANCNFSM47ERVFCA> .