Add query history sorting for remote queries#1235
Merged
aeisenberg merged 3 commits intomainfrom Mar 29, 2022
Merged
Conversation
Also, fix two smaller issues: - Ensure the `Open Query Directory` command opens inside the specified directory. - Ensure label changes are saved across restarts.
shati-patel
approved these changes
Mar 28, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me! Just a few minor comments 🎉
extensions/ql-vscode/CHANGELOG.md
Outdated
| ## [UNRELEASED] | ||
|
|
||
| - Fix a bug where the AST viewer was not synchronizing its selected node when the editor selection changes. [#1230](https://github.com/github/vscode-codeql/pull/1230) | ||
| - Open the directory in the finder/explorer (instead of just highlighting it) when running the command "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235) |
Contributor
There was a problem hiding this comment.
Small typo ✍🏽
Suggested change
| - Open the directory in the finder/explorer (instead of just highlighting it) when running the command "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235) | |
| - Open the directory in the finder/explorer (instead of just highlighting it) when running the "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235) |
extensions/ql-vscode/CHANGELOG.md
Outdated
|
|
||
| - Fix a bug where the AST viewer was not synchronizing its selected node when the editor selection changes. [#1230](https://github.com/github/vscode-codeql/pull/1230) | ||
| - Open the directory in the finder/explorer (instead of just highlighting it) when running the command "Open query directory" command from the query history view. [#1235](https://github.com/github/vscode-codeql/pull/1235) | ||
| - Ensure query label changes are persisted across restarts. [#1235](https://github.com/github/vscode-codeql/pull/1235) |
Contributor
There was a problem hiding this comment.
Maybe we can clarify what these labels are 💡 Something like this?
Suggested change
| - Ensure query label changes are persisted across restarts. [#1235](https://github.com/github/vscode-codeql/pull/1235) | |
| - Ensure query label changes in the query history view are persisted across restarts. [#1235](https://github.com/github/vscode-codeql/pull/1235) |
| } | ||
| } else if (finalSingleItem.t === 'remote') { | ||
| p = path.join(this.queryStorageDir, finalSingleItem.queryId); | ||
| externalFilePath = path.join(this.queryStorageDir, finalSingleItem.queryId, 'timestamp'); |
Contributor
There was a problem hiding this comment.
Nice use of the timestamp file! ⏲️
| } | ||
|
|
||
| if (p) { | ||
| if (externalFilePath) { |
Contributor
There was a problem hiding this comment.
This is probably a fringe case, but is it worth also throwing a Failed to open error when this path doesn't exist (e.g. if a user has deleted the timestamp for some reason)?
At the moment it fails silently.
Contributor
Author
There was a problem hiding this comment.
Hmmm...unfortunately, the revealFileInOS command does not throw an error if the file doesn't exist. I guess I can add a fs.pathExists check before trying to open.
Also, fix some changelog notes.
Contributor
Author
|
@shati-patel can you take another look and see if your comment is addressed? |
shati-patel
approved these changes
Mar 29, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM 🙌🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, fix two smaller issues:
Open Query Directorycommand opens inside the specifieddirectory.
Fixes #1204
Checklist
ready-for-doc-reviewlabel there.