Skip to content

Variant analysis: Remove handling of invalid repos#1231

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/invalid-repos
Mar 31, 2022
Merged

Variant analysis: Remove handling of invalid repos#1231
shati-patel merged 1 commit intomainfrom
shati-patel/invalid-repos

Conversation

@shati-patel
Copy link
Contributor

This is now done automatically on the API side (see internal issue/PR).

Checklist

N/A - internal only 🔱

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer.

@aeisenberg aeisenberg self-requested a review March 25, 2022 16:41
@aeisenberg
Copy link
Contributor

Removing approval since this PR is still a draft.

This is now done automatically on the API side
@shati-patel shati-patel force-pushed the shati-patel/invalid-repos branch from 20368a3 to 3e62275 Compare March 30, 2022 10:01
@shati-patel shati-patel marked this pull request as ready for review March 30, 2022 12:53
@shati-patel shati-patel requested review from a team as code owners March 30, 2022 12:53
@shati-patel
Copy link
Contributor Author

Tested with the internal changes, and things look good!

  • If all repos are invalid, you get an error No repositories could be queried
  • Otherwise, the API only runs on the valid repos

@shati-patel shati-patel merged commit bd9776c into main Mar 31, 2022
@shati-patel shati-patel deleted the shati-patel/invalid-repos branch March 31, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants