Skip to content

Add pre-push hook check to block leftover .only()s#1189

Merged
charisk merged 3 commits intomainfrom
charisk/mocha-forbid-only
Mar 8, 2022
Merged

Add pre-push hook check to block leftover .only()s#1189
charisk merged 3 commits intomainfrom
charisk/mocha-forbid-only

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Mar 7, 2022

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works fine for me (using Git Bash on Windows), though I'll let someone else take a look too 🌷

@charisk charisk marked this pull request as ready for review March 7, 2022 13:45
@charisk charisk requested a review from a team as a code owner March 7, 2022 13:45
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@charisk charisk force-pushed the charisk/mocha-forbid-only branch from 43a66a3 to dd48a2a Compare March 8, 2022 08:44
@charisk charisk merged commit 3fc3b25 into main Mar 8, 2022
@charisk charisk deleted the charisk/mocha-forbid-only branch March 8, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants