Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Conversation

@BurkovBA
Copy link

@BurkovBA BurkovBA commented Mar 5, 2018

Current integration of GoCD with github is obsolete and doesn't work.

I asked GoCD maintainers about it and they pointed me to this github repository and suggested that I fix this: gocd/gocd#4431. I've introduced the appropriate changes to essentially replicate the behaviour of webhook interface.

Unfortunately, I was unable to test this on my local machine. Currently one unit test should surely fail due to invalid webhookSecret value.

Please, take a look.

@ketan
Copy link

ketan commented Mar 5, 2018

This will almost entirely break compatibility for existing users of this github service who are using an older version of GoCD. I think we'll need to introduce a change in a manner that works for old and new versions of GoCD, probably with a checkbox that allows for some fallback between different versions of GoCD without breaking compatibility.

@gjtorikian
Copy link
Contributor

Thanks for the pull request! As services have been deprecated for some time, we're only accepting critical security bug fixes. Since GoCD already has a webhook integration, we suggest that users migrate to that path.

@gjtorikian gjtorikian closed this Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants