This repository was archived by the owner on Jan 31, 2019. It is now read-only.
GoCD service integration update #1238
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current integration of GoCD with github is obsolete and doesn't work.
I asked GoCD maintainers about it and they pointed me to this github repository and suggested that I fix this: gocd/gocd#4431. I've introduced the appropriate changes to essentially replicate the behaviour of webhook interface.
Unfortunately, I was unable to test this on my local machine. Currently one unit test should surely fail due to invalid
webhookSecretvalue.Please, take a look.