Use docker for CI replica tests, deprecate dbdeployer #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiji163
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI replica tests to use Docker Compose instead of dbdeployer and upgrades runner images to Ubuntu 22.04.
- Updated docker-compose configuration to include additional MySQL command options and environment variables for percona-server.
- Revised documentation to reflect new local test usage with Docker Compose.
- Modified GitHub Actions workflow to run tests on Ubuntu 22.04 with an updated matrix of MySQL images.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| localtests/docker-compose.yml | Added "--character-set-server=utf8mb4" to commands and included INIT_ROCKSDB env for Percona. |
| doc/local-tests.md | Updated test description and added instructions for running tests with Docker Compose. |
| .github/workflows/replica-tests.yml | Removed old Ubuntu 20.04 build job and modified the matrix to test multiple MySQL images. |
Files not reviewed (2)
- script/cibuild-gh-ost-replica-tests: Language not supported
- script/docker-gh-ost-replica-tests: Language not supported
hugodorea
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of dbdeployer for CI tests in favor of docker and upgrades runner images to Ubuntu 22.04.
Ubuntu 20.04 action runners are deprecated, which we use for running CI replica tests. Since dbdeployer isn't working out of the box on Ubuntu 22.04 runners I'm taking the opportunity to move the CI replica tests to use docker compose. This means we can deprecate the use of the unmaintained dbdeployer and gh-ost-ci-env.
We run the
localtestson the following docker images