Different behavior in cleanup with/without AttemptInstantDDL

[pasha132]

Hi all!

It seems that there is a different behavior in case of successful instant DDL and usual migrations.

Successful instant branch ends with "success" hook and return: https://github.com/github/gh-ost/blob/v1.1.7/go/logic/migrator.go#L374. As the long way have a finalCleanup step: https://github.com/github/gh-ost/blob/v1.1.7/go/logic/migrator.go#L452.

At least this leads to gho/ghc leftovers (but maybe there are more differences under the hood).

Is it possible to fix this difference if it is unexpected behavior, or expose changelog table to "success" hook for manual cleanup?

Thanks in advance!

[meiji163]

closed by #1520