Conversation
octosteve
reviewed
Jul 9, 2024
pkg/classroom/classroom.go
Outdated
|
|
||
| type GithubRepository struct { | ||
| Id int `json:"id"` | ||
| Name string `json:"name"` |
Collaborator
There was a problem hiding this comment.
@jalafel Spacing looks off here. Try running go fmt.
octosteve
previously approved these changes
Jul 9, 2024
megan-arellano
approved these changes
Jul 10, 2024
megan-arellano
left a comment
megan-arellano
left a comment
There was a problem hiding this comment.
Took me a second to understand why we don't need the GithubRepository Name function, but I believe it's bc you changed the serializer so it's an accepted value. Anyway, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes a bug where the
gh classroom clone student-reposcommand would fail if any repositories could not be cloned and was due to an unhandled error. This PR adds a--verboseflag to the command to enable verbose error output and gracefully continue cloning the remaining repositories if any fail.Closes: #69
What should reviewers focus on?
In addition, this PR abstracts the cloning of repositories to a separate function
utils.CloneRepositoryto improve testability and maintainability.This PR also removes the
Name()function fromacceptAssignment.Repository.Name()and replaces it withacceptAssignment.Repository.Name. On GitHub Classroom, I've opened a PR to update theReposerializer to include thenameattribute.