Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Large Payload Tester agentic workflow to add GitHub tool access, broaden allowed network domains, reduce secret repetition in generated payload data, and upload additional artifacts after runs.
Changes:
- Enable GitHub tool access (toolsets) and add a GitHub MCP server entry.
- Adjust network allowlist (adds
goanddocker.io) and tweak payload generation so the secret appears only once in the large array. - Add a post-step/artifact upload of “test results” directories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/large-payload-tester.md | Adds GitHub tooling/server config, changes payload JSON generation, and introduces a post-step artifact upload. |
| .github/workflows/large-payload-tester.lock.yml | Recompiled lockfile reflecting the new allowlist, payload generation, and artifact upload step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -87,7 +97,7 @@ steps: | |||
| .test_timestamp = $timestamp | | |||
| .data.metadata.repository = $repo | | |||
| .data.metadata.workflow_run_url = $url | | |||
There was a problem hiding this comment.
The test agent prompt (.github/agentics/large-payload-tester.md) expects to find a secret_reference when reading large-test-file.json. With this change, secret_reference only exists on a single array element (index 1000), so any logic that reads the first element / a fixed path will fail to find the secret. To keep the test deterministic, either store the secret in a stable location (e.g., a dedicated top-level field) or update the agent prompt/verification logic accordingly and recompile the workflow.
| .data.metadata.workflow_run_url = $url | | |
| .data.metadata.workflow_run_url = $url | | |
| .secret_reference = $secret | |
| post-steps: | ||
| - name: Upload Test Results | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: mcp-stress-test-results |
There was a problem hiding this comment.
This artifact upload appears copied from the MCP stress test workflow: the artifact name (mcp-stress-test-results) doesn’t match this workflow and the referenced directories (/tmp/mcp-stress-results/, /tmp/mcp-stress-test/logs/) are not created anywhere in the large-payload tester flow. This will likely produce empty artifacts or noisy warnings; either write results to these paths (and document it in the agent prompt) or change/remove this post-step to upload relevant large-payload outputs instead.
| - if: always() | ||
| name: Upload Test Results | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: mcp-stress-test-results | ||
| path: | | ||
| /tmp/mcp-stress-results/ | ||
| /tmp/mcp-stress-test/logs/ | ||
| retention-days: 30 |
There was a problem hiding this comment.
This upload-artifact step collects /tmp/mcp-stress-results/ and /tmp/mcp-stress-test/logs/, but this workflow doesn’t appear to create/populate those directories (they’re associated with the nightly stress test prompt). If they stay empty/missing, the step will be ineffective and may emit warnings on every run. Consider removing this step or switching it to upload directories that this workflow actually generates (or ensure the agent writes results to these paths).
No description provided.