Remove local build steps, use standard GHCR image#1731
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the “Smoke AllowOnly” workflow by removing local build/runtime setup steps and relying on the standard prebuilt MCP Gateway image flow already used by the compiled workflow.
Changes:
- Removed Go runtime setup and GOROOT capture from the workflow.
- Removed Docker Buildx setup and the local
docker buildstep forghcr.io/github/gh-aw-mcpg:latest. - Updated the locked workflow to reflect the reduced setup and tightened allowed-domain lists accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/smoke-allowonly.md | Drops local Go/Docker build steps from the workflow source definition. |
| .github/workflows/smoke-allowonly.lock.yml | Removes the corresponding generated steps and prunes allowlisted Go-related domains. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.