fix: use 'target' (singular) for setup-rust-toolchain action input#1715
Merged
fix: use 'target' (singular) for setup-rust-toolchain action input#1715
Conversation
The actions-rust-lang/setup-rust-toolchain action expects 'target' not 'targets'. The typo caused wasm32-wasip1 to not be installed, failing the WASM guard build in the release workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release workflow configuration to use the correct input name for installing the WASI Rust target during the Docker/release build.
Changes:
- Replace
targets: wasm32-wasip1withtarget: wasm32-wasip1foractions-rust-lang/setup-rust-toolchain. - Apply the same change to both the source workflow (
release.md) and the generated locked workflow (release.lock.yml).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.md | Fixes the Rust toolchain action input key so the WASI target is configured correctly in the workflow source. |
| .github/workflows/release.lock.yml | Mirrors the same fix in the pinned/locked workflow used for execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
actions-rust-lang/setup-rust-toolchainaction expectstarget(singular), nottargets(plural). The typo causedwasm32-wasip1to silently not be installed, failing the WASM guard build in the release workflow with:The action logged:
Fix:
targets:→target:in bothrelease.mdandrelease.lock.yml.