Conversation
Pin MCP Gateway JSON schema validation URL to latest stable release tag v0.53.2 (from v0.51.6) for reproducible, deterministic validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Pins the MCP Gateway configuration JSON schema reference to the gh-aw v0.53.2 release to keep schema validation deterministic across runs.
Changes:
- Updated the schema fetch URL used by config validation to
v0.53.2. - Updated the schema reference URL used in config validation error footers to
v0.53.2. - Updated a test expectation that asserts the schema URL appears in enhanced error output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/config/validation_schema.go | Bumps the pinned schema URL used for remote schema fetch/compile during validation. |
| internal/config/rules/rules.go | Bumps the schema reference URL shown in validation error footers. |
| internal/config/validation_schema_test.go | Updates the hardcoded schema URL string expected in enhanced error messages. |
Comments suppressed due to low confidence (1)
internal/config/validation_schema.go:44
schemaURLduplicatesrules.SchemaURL(both now point at the same pinned URL). Consider definingschemaURLin terms ofrules.SchemaURL(or otherwise centralizing it) to avoid the two getting out of sync on the next bump.
// Alternative: Embed the schema using go:embed directive for zero network dependency.
schemaURL = "https://raw.githubusercontent.com/github/gh-aw/v0.53.2/docs/public/schemas/mcp-gateway-config.schema.json"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Error:", | ||
| "Details:", | ||
| "https://raw.githubusercontent.com/github/gh-aw/v0.51.6/docs/public/schemas/mcp-gateway-config.schema.json", | ||
| "https://raw.githubusercontent.com/github/gh-aw/v0.53.2/docs/public/schemas/mcp-gateway-config.schema.json", |
There was a problem hiding this comment.
This test hardcodes the full versioned schema URL. To reduce churn and prevent future version bumps from missing this assertion, consider referencing the package’s schemaURL (same package) or rules.SchemaURL instead of duplicating the literal string here.
| "https://raw.githubusercontent.com/github/gh-aw/v0.53.2/docs/public/schemas/mcp-gateway-config.schema.json", | |
| schemaURL, |
| // Current schema version: v0.50.7 | ||
| // | ||
| // Alternative: Embed the schema using go:embed directive for zero network dependency. | ||
| schemaURL = "https://raw.githubusercontent.com/github/gh-aw/v0.51.6/docs/public/schemas/mcp-gateway-config.schema.json" | ||
| schemaURL = "https://raw.githubusercontent.com/github/gh-aw/v0.53.2/docs/public/schemas/mcp-gateway-config.schema.json" |
There was a problem hiding this comment.
The surrounding documentation is now inconsistent with the pinned schema URL: it still mentions fetching from the main branch and lists Current schema version: v0.50.7. Please update the comment block to reflect the pinned v0.53.2 URL (or whatever strategy is intended) so it stays accurate.
This issue also appears on line 43 of the same file.
See below for a potential fix:
// The schema is fetched from a specific tagged release of gh-aw (see schemaURL below),
// rather than from the main branch, to ensure stable and reproducible validation.
//
// To update to a newer pinned schema version:
// 1. Check the latest gh-aw release: https://github.com/github/gh-aw/releases
// 2. Update the schemaURL below to use the desired version tag
// 3. Run tests to ensure compatibility: make test
// 4. Update this comment with the new version number
//
// Current schema version: v0.53.2 (pinned via the tag in schemaURL)
Schema URL Update
Updates the MCP Gateway JSON schema validation URL from
v0.51.6tov0.53.2.Files Changed
internal/config/validation_schema.go—schemaURLvariable updated tov0.53.2internal/config/rules/rules.go—SchemaURLconstant updated tov0.53.2internal/config/validation_schema_test.go— hardcoded schema URLs updated tov0.53.2Why
Pinning to a specific release tag ensures reproducible, deterministic configuration validation — the schema won't silently change between runs.
Release Notes
See the gh-aw release notes for changes in this schema version.
Warning
The following domain was blocked by the firewall during workflow execution:
invalidhostthatdoesnotexist12345.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.