[log] Add debug logging to dockerutil/env.go#1522
Merged
Conversation
Add logger to internal/dockerutil/env.go to trace Docker -e flag environment variable expansion. Logs: - Function entry with arg count - Each env var expansion (found vs not found in process environment) - Completion with output count This helps debug issues where Docker container environment variables are unexpectedly missing or not being passed through correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug-level tracing to internal/dockerutil/env.go so it’s easier to understand how Docker -e VAR_NAME arguments are expanded (or not) based on the gateway process environment.
Changes:
- Introduces a
dockerutil:envnamespaced logger for this file. - Adds debug logs at function entry/exit and when env vars are expanded or missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a debug logger to
internal/dockerutil/env.goto trace Docker-eflag environment variable expansion.What was added
var logDockerutil = logger.New("dockerutil:env")following the project'spkg:filenamenaming conventionExpandEnvArgs:Why this is useful
ExpandEnvArgsis called when building Docker command arguments, converting passthrough-e VAR_NAMEflags to-e VAR_NAME=value. Without logging, there's no visibility into:The "not found" log is especially valuable - it highlights env vars that are referenced in config but not set in the environment, which is a common source of unexpected Docker container behavior.
Debug usage
Quality checklist
pkg:filenameconvention (dockerutil:env)