Install Go 1.25.0 before language support testing#1026
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Language Support Tester agentic workflow to pre-install the Go toolchain (from go.mod) before Serena runs, avoiding post-firewall toolchain downloads that block language support tests.
Changes:
- Added an
actions/setup-go@v6(pinned SHA) setup step to the agentic workflow frontmatter. - Recompiled the workflow into
language-support-tester.lock.yml, incorporating the new setup step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/language-support-tester.md | Adds a pre-run step to install Go based on go.mod so Serena can analyze Go code without downloading toolchains during the run. |
| .github/workflows/language-support-tester.lock.yml | Updates the compiled workflow to include the setup-go step; also includes additional generated changes from a newer gh-aw/runner toolchain. |
Comments suppressed due to low confidence (1)
.github/workflows/language-support-tester.lock.yml:18
- The compiled lock workflow includes an implicit gh-aw toolchain upgrade (generated by gh-aw v0.45.4). This introduces many unrelated workflow changes beyond adding setup-go, making the PR harder to review/audit. Consider recompiling with the repository’s current gh-aw version, or split the gh-aw/awf upgrades into a separate PR (e.g., via
gh aw upgrade).
# This file was automatically generated by gh-aw (v0.45.4). DO NOT EDIT.
#
# To update this file, edit the corresponding .md file and run:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| awf_version: "v0.19.1", | ||
| awmg_version: "v0.1.4", |
There was a problem hiding this comment.
This lockfile change bumps the firewall runner components (awf version/image-tag and downloaded images) from 0.18.0 to 0.19.1. That’s a behavioral change unrelated to installing Go, and could affect networking/runner behavior; it would be safer to keep these version bumps in a dedicated upgrade PR (or explicitly call them out in the PR description with rationale/testing).
This issue also appears on line 16 of the same file.
| - name: Create gh-aw temp directory | ||
| run: bash /opt/gh-aw/actions/create_gh_aw_tmp_dir.sh | ||
| - name: Set up Go | ||
| uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # 4dc6199c7b1a012772edbd06daecab0f50c9053c |
There was a problem hiding this comment.
The actions/setup-go step comment currently repeats the commit SHA (# 4dc6...) instead of a human-readable version label (e.g., # v6 like other workflows). Updating the comment would improve maintainability when scanning the workflow history.
| uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # 4dc6199c7b1a012772edbd06daecab0f50c9053c | |
| uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v5 |
Serena MCP server requires Go 1.25.0 to analyze Go code in the workspace. Network firewall restrictions prevent downloading the toolchain from proxy.golang.org during workflow execution, blocking all language support tests.
Changes
Added
actions/setup-go@v6step to.github/workflows/language-support-tester.mdfrontmatter4dc6199c7b1a012772edbd06daecab0f50c9053c(consistent with CI workflow)go.modviago-version-fileparametercache: trueCompiled workflow to
.github/workflows/language-support-tester.lock.ymlContext
The
steps:section in GitHub Agentic Workflow frontmatter allows pre-configuring runner environment before agent execution. When Serena mounts${GITHUB_WORKSPACE}and activates the Go project, the toolchain is now available without network downloads.Unblocks testing for Go, TypeScript/JavaScript, and Python language support.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.45.4/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.45.4 --jq .object.sha(http block)https://api.github.com/user/usr/bin/gh gh api user --jq .login(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.