This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Closed
Conversation
…the repo; Adding some logs
shana
force-pushed
the
ui/publish-for-all-the-world-to-see
branch
from
b7a5cf9 to
44925d7
Compare
shana
force-pushed
the
ui/publish-for-all-the-world-to-see
branch
from
44925d7 to
9589c80
Compare
…to-see # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Subview.cs
…for-all-the-world-to-see # Conflicts: # src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs
Contributor
|
It was suggested at one point, that we try to always use the v3 Repos - Create method that takes an organization and supply the login username instead of an organization. The hope was that would help secure us from accidental publishing to a new user when we were expecting the previously authenticated user. I did some tests and I see that is not possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
Depends on:
When a local repo doesn't exist on GitHub, we should give the user an opportunity to publish it from Unity so that they can start sharing the project with other teammates.
This pull request implements the UI for publishing a repo (but still needs hooking up):
FUN GIF TIME! 🎥 ✨
❓ When the user isn't logged in, should we pop open the Authentication window instead so that they can publish to GitHub? If we do, is there a way to "remember" that they were in the middle of publishing and replace the window with the Publish window?