Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Split the commit message into the subject line and the body#205

Merged
shana merged 1 commit intogithub-for-unity:masterfrom
shiena:fix-commit-message
Aug 20, 2017
Merged

Split the commit message into the subject line and the body#205
shana merged 1 commit intogithub-for-unity:masterfrom
shiena:fix-commit-message

Conversation

@shiena
Copy link
Contributor

@shiena shiena commented Aug 19, 2017

Description of the Change

fixes #206

Change commit message to recommended style.

current commit message

summary
1st line of description
2nd line of description
3rd line of description
...

changed commit message

summary

1st line of description
2nd line of description
3rd line of description
...

refs

Alternate Designs

None

Benefits

git log --online and git shortlog etc will print only the summary.

Possible Drawbacks

None

Applicable Issues

N/A

@StanleyGoldman
Copy link
Contributor

Hey @shiena. Thanks for another pull request.

Can you do me a favor? Can you create an issue for the problem you are fixing here?

It's a formality we have that helps our reporting for release notes.
We don't create issues only when refactoring or code cleanup, but if it is a bug fix or enhancement we need an issue.

@shiena
Copy link
Contributor Author

shiena commented Aug 20, 2017

@StanleyGoldman OK. I posted #206 !

@shana
Copy link
Member

shana commented Aug 20, 2017

@shiena This is awesome, thank you!

@shana shana merged commit 968c158 into github-for-unity:master Aug 20, 2017
@shiena shiena deleted the fix-commit-message branch August 21, 2017 00:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The commit log is not the recommended style

3 participants