feat(dashboards): Add preferredPolarity to widget thresholds serializer #105407
+98
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105407 +/- ##
===========================================
- Coverage 80.58% 80.57% -0.01%
===========================================
Files 9441 9441
Lines 404940 404953 +13
Branches 25684 25684
===========================================
+ Hits 326304 326306 +2
- Misses 78167 78178 +11
Partials 469 469 |
|
|
||
|
|
||
| class ThresholdType(TypedDict): | ||
| class ThresholdTypeOptional(TypedDict, total=False): |
Contributor
Author
There was a problem hiding this comment.
Creating a class specifically for the optional preferredPolarity because thats what the openapi generator recognizes
![cursor[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
preferredPolarityattribute to the widgetThresholdTypeserializer to enable choosing direction of big number threshold config