docs(python): Update attachment docs for 2.x#10851
Merged
antonpirker merged 3 commits intomasterfrom Sep 6, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
sl0thentr0py
requested changes
Jul 25, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/python-attachment-docs
branch
2 times, most recently
from
01686bd to
25510c3
Compare
Member
Author
|
Hello, could we please get a @getsentry/docs review here? Thanks in advance. |
lizokm
approved these changes
Aug 8, 2024
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
A small wording suggestion, otherwise this looks great. Thanks for updating!
Update attachment docs to reflect new API added in Python SDK 2.0.0, and introduce other general improvements to the page. Fixes: #10844 Related: getsentry/sentry-python#3340
Co-authored-by: Liza Mock <liza.mock@sentry.io>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/python-attachment-docs
branch
from
7976dc2 to
a2f2b65
Compare
lforst
reviewed
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Update attachment docs to reflect new API added in Python SDK 2.0.0, and introduce other general improvements to the page.
Depends on getsentry/sentry-python#3342, which adds parameter documentation to the API Docs.
Fixes: #10844
Related: getsentry/sentry-python#3340
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: