Add support for translate: false fields in multilang setups#3
Open
johannschopplich wants to merge 1 commit intogetkirby:mainfrom
Open
Add support for translate: false fields in multilang setups#3johannschopplich wants to merge 1 commit intogetkirby:mainfrom
translate: false fields in multilang setups#3johannschopplich wants to merge 1 commit intogetkirby:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for getting field content for secondary languages if the field is created with
translate: false.Summary of changes
nullwith their default language counterparts.Reasoning
Currently, fields with
translate: falseare displayed with their empty state in the Panel. Furthermore, accessing the field content will result in a empty value.This is because the primary language's data for the field is not retrieved from the DB.
Additional context
This is probably not the most semantic or correct solution, but it works for now.