Skip to content

chore: update project delete button tooltip text#1464

Merged
arnestrickmann merged 1 commit intomainfrom
emdash/chore-project-tooltip-changed-5cf
Mar 13, 2026
Merged

chore: update project delete button tooltip text#1464
arnestrickmann merged 1 commit intomainfrom
emdash/chore-project-tooltip-changed-5cf

Conversation

@arnestrickmann
Copy link
Contributor

Summary

  • Updated the tooltip and title text on the project delete button from "Delete project" to "Remove the project from Emdash" for clarity
  • Better communicates that this action removes the project from Emdash rather than deleting files from disk

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 13, 2026 7:25pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 13, 2026

Greptile Summary

This PR updates the tooltip and title attribute on the ProjectDeleteButton component from "Delete project" to "Remove the project from Emdash", making it clearer to users that the action removes the project from the application rather than deleting files from disk. The change is minimal and low-risk, touching only two display strings in a single component.

  • Updated title attribute on the trigger Button (line 87)
  • Updated TooltipContent text (line 102)
  • The default aria-label prop value (line 39) was not updated to match the new wording, creating a minor inconsistency if the component is ever used without an explicit aria-label override. The current sole call site in ProjectMainView.tsx always passes an explicit label, so there is no immediate user-facing impact.

Confidence Score: 5/5

  • This PR is safe to merge — it is a two-line text-only change with no logic, data, or behavior impact.
  • The change is purely cosmetic (tooltip and title strings), has no effect on application logic, and the only call site already supplies an explicit aria-label. The single minor inconsistency (default aria-label not updated) has no current user-visible impact.
  • No files require special attention.

Important Files Changed

Filename Overview
src/renderer/components/ProjectDeleteButton.tsx Tooltip title attribute and TooltipContent text updated from "Delete project" to "Remove the project from Emdash"; the default aria-label prop value was not updated to match.

Sequence Diagram

sequenceDiagram
    actor User
    participant Button as ProjectDeleteButton
    participant Tooltip as TooltipContent
    participant Dialog as AlertDialog

    User->>Button: Hover
    Button-->>Tooltip: Show "Remove the project from Emdash"
    User->>Button: Click
    Button->>Dialog: Open confirmation dialog
    Dialog-->>User: "Delete project?" title + risks summary
    User->>Dialog: Acknowledge risks (if any) + click Delete
    Dialog->>Button: onConfirm()
    Button-->>User: isDeleting spinner shown
Loading

Comments Outside Diff (1)

  1. src/renderer/components/ProjectDeleteButton.tsx, line 39 (link)

    Default aria-label not updated to match new tooltip text

    The default value for the aria-label prop still reads 'Delete project', while the visible tooltip and title attribute were updated to 'Remove the project from Emdash'. If the component is ever rendered without an explicit aria-label (e.g. in a future call site or in tests), screen readers will announce a label that doesn't match the visible tooltip, creating an accessibility inconsistency.

Last reviewed commit: f8c9209

@arnestrickmann arnestrickmann merged commit 1ce4ecd into main Mar 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant