fix: prevent Create PR button overflow in narrow sidebar#1420
Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom Mar 12, 2026
Merged
fix: prevent Create PR button overflow in narrow sidebar#1420arnestrickmann merged 1 commit intogeneralaction:mainfrom
arnestrickmann merged 1 commit intogeneralaction:mainfrom
Conversation
|
@naaa760 is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR fixes button clipping in the narrow right sidebar by adding
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/FileChangesPanel.tsx | Two targeted Tailwind class changes prevent button overflow in narrow sidebar: adds flex-wrap and min-w-0 to both button container divs. In the second change (no-changes branch), shrink-0 is also removed to allow the container to shrink — which is necessary for the fix to actually work. Slightly inconsistent outer-container behavior between the two branches (one has flex-wrap on the outer wrapper, the other does not) but does not cause a bug. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[FileChangesPanel header row] --> B{hasChanges?}
B -- Yes --> C["Outer: flex w-full flex-wrap justify-between"]
C --> D["Left: stats + staged badge"]
C --> E["Right buttons container\n(BEFORE): flex items-center gap-2\n(AFTER): flex min-w-0 flex-wrap items-center gap-2"]
E --> F["Changes btn · Stage All btn · PrActionButton"]
B -- No --> G["Outer: flex w-full justify-between\n(no flex-wrap)"]
G --> H["Left: em-dash stats (shrink-0)"]
G --> I["Right buttons container\n(BEFORE): flex shrink-0 items-center gap-2\n(AFTER): flex min-w-0 flex-wrap items-center gap-2"]
I --> J["Changes btn · PR status / Create PR btn"]
style E fill:#d4edda,stroke:#28a745
style I fill:#d4edda,stroke:#28a745
Last reviewed commit: 7d69dbf
Contributor
|
Hi @naaa760 Thank you |
Contributor
|
Hi @naaa760 |
Contributor
Author
see please @arnestrickmann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix : #1417
summary
Fixes
Snapshot
Type of change
Mandatory Tasks
Checklist
[x] I have read the contributing guide
[x] My code follows the style guidelines of this project (pnpm run format)
[x] I have checked if my changes generate no new warnings (pnpm run lint)