fix(build): pin app-builder-lib minimatch to restore mac releases#1391
Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom Mar 10, 2026
Merged
Conversation
|
@arnestrickmann is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR adds a targeted pnpm path override ( Key points:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| package.json | Adds a targeted pnpm path override app-builder-lib>minimatch: "10.1.2" alongside the existing broad version overrides. The path-specific override correctly takes precedence over the broader minimatch@10: "10.2.3" entry per pnpm resolution rules, and minimatch@10.1.2's engine requirement (`node: 20 |
| pnpm-lock.yaml | Lockfile correctly reflects the new override: both app-builder-lib snapshots (one previously resolved to minimatch@5.1.8, the other to minimatch@10.2.3) are now pinned to minimatch@10.1.2. The new package entry includes the correct integrity hash and the @isaacs/brace-expansion@5.0.1 dependency (the scoped predecessor to brace-expansion used starting in 10.2.x). |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pnpm install] --> B{Resolve minimatch\nfor app-builder-lib}
B --> C[Check path-specific override\napp-builder-lib gt minimatch]
C --> D[Override found: v10.1.2\nTakes precedence]
D --> E[minimatch v10.1.2 resolved\nfor app-builder-lib]
E --> F[isaacs/brace-expansion v5.0.1\nas transitive dep]
B --> G[Broad version override\nminimatch v10 to v10.2.3]
G --> H[Superseded by path override\nNot applied to app-builder-lib]
E --> I[electron-builder runs\napp-builder-lib uses v10.1.2]
I --> J[dist glob patterns\nmatch correctly]
J --> K[dist/main/main/entry.js\npackaged into app.asar]
K --> L[Mac DMG build succeeds]
style D fill:#22c55e,color:#fff
style H fill:#f97316,color:#fff
style L fill:#22c55e,color:#fff
Last reviewed commit: fc9460b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
app-builder-libtominimatch@10.1.2via pnpm overrides.This fixes the mac release packaging regression introduced after the broader minimatch security override update, where
electron-builderproduced anapp.asarwithout thedist/output and then failed with:Application entry file "dist/main/main/entry.js" ... was not found in this archiveRoot cause
The
v0.4.28dependency update forced newerminimatchversions across the tree. With a fresh install,app-builder-libresolved a newer minimatch version and stopped packagingdist/**/*intoapp.asarduring mac builds.Changes
app-builder-lib>minimatchto10.1.2pnpm-lock.yamlaccordinglyVerification
Reproduced the failure locally, then verified the fix by rerunning:
pnpm exec electron-builder --mac dmg --x64 --publish never --config.npmRebuild=falseResult:
dist/main/main/entry.jswas present inside the packagedapp.asarNotes
This keeps the broader minimatch security overrides in place and only pins the Electron Builder path back to the last known working version.