Skip to content

fix(settings): clarify notification provider support#1324

Merged
rabanspiegel merged 1 commit intomainfrom
emdash/feat-circle-notification-claude-8qy
Mar 6, 2026
Merged

fix(settings): clarify notification provider support#1324
rabanspiegel merged 1 commit intomainfrom
emdash/feat-circle-notification-claude-8qy

Conversation

@rabanspiegel
Copy link
Contributor

@rabanspiegel rabanspiegel commented Mar 6, 2026

Summary

  • add an info tooltip to the notification settings header
  • clarify that notifications are supported by Claude Code, Codex, Droid, and OpenCode

Testing

  • pnpm run format
  • pnpm run lint
  • pnpm run type-check
  • pnpm exec vitest run

Note

Low Risk
Low risk UI-only change that adds a tooltip and icon without altering notification behavior or persistence logic.

Overview
Adds an Info icon + tooltip next to the Notifications master toggle to explicitly list which agents support notifications (Claude Code, Codex, Droid, OpenCode). No changes to the underlying notification settings logic; this is a presentation-only clarification.

Written by Cursor Bugbot for commit 9f3eac8. This will update automatically on new commits. Configure here.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 6, 2026 5:00am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 6, 2026

Greptile Summary

This PR adds a small info tooltip () next to the "Notifications" label in the settings card to surface which AI providers (Claude Code, Codex, Droid, and OpenCode) support the notification feature — improving discoverability for users who wonder why notifications might not arrive for their agent.

Key changes:

  • Wraps the "Notifications" heading in a flex row and appends an accessible <button> icon that triggers a Radix UI Tooltip on hover/focus.
  • Imports Info from lucide-react and Tooltip* components from the local ui/tooltip wrapper.
  • aria-label and type="button" are correctly set on the trigger button.

The implementation is functionally correct, well-typed, and accessible. The change is minimal and safe to merge.

Confidence Score: 5/5

  • Safe to merge; the tooltip is purely additive and all changes are minimal, correctly typed, and accessible.
  • The PR implements a straightforward UI enhancement with no logic errors, type issues, or accessibility concerns. The code is clean and follows the existing patterns in the codebase. No functional problems detected.
  • No files require special attention.

Sequence Diagram

sequenceDiagram
    actor User
    participant Button as Info Button (TooltipTrigger)
    participant Provider as TooltipProvider (local)
    participant Content as TooltipContent (Portal)

    User->>Button: hover / focus
    Button->>Provider: trigger open (after 150ms delay)
    Provider->>Content: render via Portal (z-[240])
    Content-->>User: "Supported by Claude Code, Codex, Droid, and OpenCode."
    User->>Button: mouse leave / blur
    Button->>Provider: trigger close
    Provider->>Content: animate out & unmount
Loading

Last reviewed commit: 9f3eac8

@rabanspiegel rabanspiegel merged commit 34415ab into main Mar 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant