feat(ui): always show changes button in file changes panel top bar#1272
Merged
arnestrickmann merged 2 commits intogeneralaction:mainfrom Mar 4, 2026
Merged
Conversation
|
@jschwxrz is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR unifies the two conditional top-bar layouts in Key changes:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/FileChangesPanel.tsx | Two separate conditional top-bar layouts unified into one; "Changes" button is now always rendered when onOpenChanges is provided; empty state shows —·— instead of a static "Changes" label; all PR action logic preserved unchanged. Minor: flex-wrap was present on the old hasChanges container but is absent from the new unified one. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Top Bar Renders] --> B{hasChanges?}
B -- Yes --> C["Left: +additions · -deletions"]
B -- No --> D["Left: — · — (em-dashes)"]
C --> E[Right side]
D --> E
E --> F{onOpenChanges prop?}
F -- Yes --> G["Always render 'Changes' button ✅"]
F -- No --> H[No Changes button]
G --> I{hasChanges?}
H --> I
I -- Yes --> J[PrActionButton]
I -- No --> K{isPrLoading?}
K -- Yes --> L[Spinner]
K -- No --> M{pr exists?}
M -- Yes --> N[View PR button]
M -- No --> O{branchStatusLoading\nor branchAhead > 0?}
O -- Yes --> P[PrActionButton]
O -- No --> Q[No PR for this task]
Last reviewed commit: bcf0a78
Contributor
|
Great catch, and makes a lot of sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
changes: